Inference module to utilize CFZ CUDNN Toggle Node in ComfyUI-Zluda#1441
Inference module to utilize CFZ CUDNN Toggle Node in ComfyUI-Zluda#1441mohnjiles merged 16 commits intoLykosAI:mainfrom
Conversation
deleted unneeded file
Summary of ChangesHello @NeuralFault, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a specialized module into the StabilityMatrix inference workflow to address CUDNN-related runtime errors that can occur during image generation, especially for users with AMD GPUs leveraging Zluda. By providing a new UI component and a corresponding backend module, users can now explicitly control CUDNN enablement and benchmarking, effectively preventing specific computation errors and improving overall stability and compatibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new inference module to toggle CUDNN for ComfyUI-Zluda, which is useful for preventing errors on AMD cards. The implementation is solid and adds the necessary UI, view models, and logic to insert the CUDNN toggle node into the inference workflow.
My review focuses on improving the clarity and consistency of the new feature. I've suggested renaming a view model property and updating the UI text to make the CUDNN toggle's behavior more intuitive for the user. I've also recommended a more descriptive title for the module and a minor code cleanup. These changes should enhance the user experience and maintainability of the new code.
StabilityMatrix.Avalonia/Controls/Inference/CfzCudnnToggleCard.axaml
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/ViewModels/Inference/CfzCudnnToggleCardViewModel.cs
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/ViewModels/Inference/Modules/CfzCudnnToggleModule.cs
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/ViewModels/Inference/Modules/CfzCudnnToggleModule.cs
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/ViewModels/Inference/Modules/CfzCudnnToggleModule.cs
Outdated
Show resolved
Hide resolved
NeuralFault
left a comment
NeuralFault
left a comment
There was a problem hiding this comment.
made some suggested changes.
StabilityMatrix.Avalonia/ViewModels/Inference/CfzCudnnToggleCardViewModel.cs
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/Controls/Inference/CfzCudnnToggleCard.axaml
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/ViewModels/Inference/Modules/CfzCudnnToggleModule.cs
Outdated
Show resolved
Hide resolved
StabilityMatrix.Avalonia/ViewModels/Inference/Modules/CfzCudnnToggleModule.cs
Outdated
Show resolved
Hide resolved
NeuralFault
left a comment
NeuralFault
left a comment
There was a problem hiding this comment.
completed suggested change that got left unresolved.
NeuralFault
left a comment
NeuralFault
left a comment
There was a problem hiding this comment.
Remove unused 'System.Linq' using directive
3 participants
For real this time.
Adds a module to SM Inference's optional Steps listing. This, when toggled on, will add the CFZ Cudnn Toggle node in ComfyUI-Zluda to SM Inference's workflow disabling Cudnn before VAE Decode to prevent "RuntimeError: GET was unable to find an engine to execute this computation" when MIOpen kicks in.
Is only a simple toggle that needs to be placed above FaceDetailer (since it itself invokes a conv2d function) in Inference's parameters, but otherwise to be the last Step module at the bottom of the list.